mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 63455: Fixed Protobuf header dependency.
Date Tue, 31 Oct 2017 22:43:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63455/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
-------

While the header files were being created correctly, the explicit
dependency in the `CUSTOM_COMMAND` did not exist. Though we depended on
`${H}`, the variable was empty as we forgot to set it.


Diffs
-----

  src/cmake/MesosProtobuf.cmake 533455e3b650dfb9e2b8c73e83c60ecc99613985 


Diff: https://reviews.apache.org/r/63455/diff/1/


Testing
-------

Re-ran CMake and inspected output files. The explicit dependency on this header now exists.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message