mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.
Date Tue, 31 Oct 2017 22:43:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/#review189761
-----------------------------------------------------------


Fix it, then Ship it!




Can you split the fix and the test? We don't usually cherry pick back the tests.


src/tests/master_slave_reconciliation_tests.cpp
Lines 721 (patched)
<https://reviews.apache.org/r/63353/#comment266992>

    TaskExecutorIds?



src/tests/master_slave_reconciliation_tests.cpp
Lines 849-851 (patched)
<https://reviews.apache.org/r/63353/#comment266993>

    Put the output on the next line here?


- Benjamin Mahler


On Oct. 27, 2017, 7:48 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63353/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 7:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the agent would sometimes clear the executor ID of
> non-command executors before sending the `ReregisterSlaveMessage`
> message.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6

> 
> 
> Diff: https://reviews.apache.org/r/63353/diff/1/
> 
> 
> Testing
> -------
> 
> Verified that the new test fails on GNU/Linux without the rest of the patch, but passes
with it.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message