mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63419: Updated tests to use `createCallKill`.
Date Tue, 31 Oct 2017 04:05:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63419/#review189687
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63419]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 30, 2017, 6:22 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63419/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 6:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
> 
> 
> Bugs: MESOS-8094
>     https://issues.apache.org/jira/browse/MESOS-8094
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated all the tests that send v1 API KILL calls to use the
> `createCallKill` test helper.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954 
>   src/tests/scheduler_tests.cpp 6df4d3254bbb4997fbe56721edff0a400703d78d 
>   src/tests/slave_tests.cpp 99b9c8222d0c15e42b2d8d6672bc197dcb37b359 
> 
> 
> Diff: https://reviews.apache.org/r/63419/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message