mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63423: Cleared the executor auth token after using it.
Date Tue, 31 Oct 2017 02:03:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63423/#review189681
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63422, 63423]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 30, 2017, 6:15 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63423/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8140
>     https://issues.apache.org/jira/browse/MESOS-8140
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the executor may run in the smae container and under
> the same credential as the user task, we should clear the
> `MESOS_EXECUTOR_AUTHENTICATION_TOKEN` environment variable
> once we sample it.
> 
> 
> Diffs
> -----
> 
>   src/executor/executor.cpp 7280951909b677e2a7b0afbcddba4a299dbe6f06 
>   src/launcher/default_executor.cpp cdb3c3e919a94996bba323fa04bfdc927d537910 
> 
> 
> Diff: https://reviews.apache.org/r/63423/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> Manual inspection of child process metadata.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message