mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 63423: Cleared the executor auth token after using it.
Date Mon, 30 Oct 2017 18:15:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63423/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-8140
    https://issues.apache.org/jira/browse/MESOS-8140


Repository: mesos


Description
-------

Since the executor may run in the smae container and under
the same credential as the user task, we should clear the
`MESOS_EXECUTOR_AUTHENTICATION_TOKEN` environment variable
once we sample it.


Diffs
-----

  src/executor/executor.cpp 7280951909b677e2a7b0afbcddba4a299dbe6f06 
  src/launcher/default_executor.cpp cdb3c3e919a94996bba323fa04bfdc927d537910 


Diff: https://reviews.apache.org/r/63423/diff/1/


Testing
-------

make check (Fedora 26)

Manual inspection of child process metadata.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message