mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63312: Updated Resources::apply for new operations.
Date Mon, 30 Oct 2017 15:25:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63312/
-----------------------------------------------------------

(Updated Oct. 30, 2017, 3:25 p.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.


Bugs: MESOS-7594
    https://issues.apache.org/jira/browse/MESOS-7594


Repository: mesos


Description
-------

This patch updated Resources::apply method to support new operations:
CREATE_VOLUME, DESTROY_VOLUME, CREATE_BLOCK and DESTROY_BLOCK. We
introduced an optional `convertedResources` field to this method for
new operations.

This patch also made sure that we don't call Resources::apply for
LAUNCH and LAUNCH_GROUP, because it does not really "convert" the
resources.


Diffs
-----

  include/mesos/resources.hpp 9f959494f5c0376aa4ebd8f2571f4b1f45c83cb3 
  include/mesos/v1/resources.hpp a6216858136c82d5ebb5da3bb22c0b8a58a3b75d 
  src/common/resources.cpp 7ee4dae1389e037531aec533a3d235ee06443ea8 
  src/examples/persistent_volume_framework.cpp 1f8f4bea7ce4d1a919034e0639b4f70e7c9961cf 
  src/master/allocator/mesos/hierarchical.cpp 5b6efe5faa3c3b10f1f714f582a155b368f8ccaf 
  src/v1/resources.cpp 5c0a196cf87b377b345e53a36ed24727d52381ca 


Diff: https://reviews.apache.org/r/63312/diff/3/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message