mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63183: Stopped awaiting the connected event in ports isolator tests.
Date Mon, 30 Oct 2017 11:43:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/
-----------------------------------------------------------

(Updated Oct. 30, 2017, 11:42 a.m.)


Review request for mesos, Alexander Rukletsov and Gaston Kleiman.


Bugs: MESOS-8094
    https://issues.apache.org/jira/browse/MESOS-8094


Repository: mesos


Description
-------

Rather than explicitly waiting for the `connected` scheduler event,
consistently apply the testing pattern from the default executor
tests. We expect that the `connected` event happens, but we only
need to synchronize the test on the `subscribed` event.


Diffs
-----

  src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b



Diff: https://reviews.apache.org/r/63183/diff/1/


Testing
-------

sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*

(Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message