mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63397: Added a map from OfferOperationID to internal operation UUID.
Date Mon, 30 Oct 2017 11:17:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63397/#review189563
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp
Lines 2995 (patched)
<https://reviews.apache.org/r/63397/#comment266691>

    I am not sure how this will be used, but it should be important to map from frameworks
to offer operation IDs (e.g., for cleanup when a framework is removed for good).
    
    We should also soon follow this up with something to prevent this map from growing without
bounds, maybe add a `TODO` here, or add minimal cleanup in https://reviews.apache.org/r/63358/.


- Benjamin Bannier


On Oct. 29, 2017, 4:50 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63397/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2017, 4:50 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a map from OfferOperationID to internal operation UUID.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac 
> 
> 
> Diff: https://reviews.apache.org/r/63397/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message