mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63256: Added a master validation 'resource::validateSingleResourceProvider'.
Date Mon, 30 Oct 2017 10:20:22 GMT


> On Oct. 25, 2017, 2:32 a.m., Greg Mann wrote:
> > src/master/validation.cpp
> > Lines 816 (patched)
> > <https://reviews.apache.org/r/63256/diff/1/?file=1867604#file1867604line816>
> >
> >     "Some resources have a resource provider and some don't"
> >     
> >     Here and below.

Maybe even `s/don't/do not/` since we are at it.

Here and below.


> On Oct. 25, 2017, 2:32 a.m., Greg Mann wrote:
> > src/tests/master_validation_tests.cpp
> > Lines 285 (patched)
> > <https://reviews.apache.org/r/63256/diff/1/?file=1867605#file1867605line285>
> >
> >     I think this might read better if you enclose each test case in a `{}` scope
and declare a new `Resources` object in each scope.

+1, would also be great to not reuse `error`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63256/#review189114
-----------------------------------------------------------


On Oct. 29, 2017, 4:46 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63256/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2017, 4:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This validates that all resources are from the same resource provider.
> We don't allow an offer operation to be operating on resources from
> different resource providers.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp f4925752f20ae8ca4de1d9b4a3d5ffc394db9585 
>   src/master/validation.cpp 42f5742386b59a983f7caaf3400c82b7ef4f8bbb 
>   src/tests/master_validation_tests.cpp 7da1be5233444aded64263d4a763fe2967459042 
> 
> 
> Diff: https://reviews.apache.org/r/63256/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message