mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 63391: Fixed the flaky SlaveTest.HTTPSchedulerSlaveRestart.
Date Sat, 28 Oct 2017 01:37:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63391/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-7972
    https://issues.apache.org/jira/browse/MESOS-7972


Repository: mesos


Description
-------

This test was trying to prevent re-registration retries, but
it resumed the clock too early! As a result, sometimes a second
re-registration occurs and the master will send an
UpdateFrameworkMessage that over-rules the one we're spoofing
in the test. One example occurs in MESOS-7972, and the agent
as a result replies directly to the scheduler since it sees
the scheduler as having a pid.


Diffs
-----

  src/tests/slave_tests.cpp 99b9c8222d0c15e42b2d8d6672bc197dcb37b359 


Diff: https://reviews.apache.org/r/63391/diff/1/


Testing
-------

Ran in repetition.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message