mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63293: Update google-glog to 0.3.5.
Date Thu, 26 Oct 2017 16:05:01 GMT


> On Oct. 25, 2017, 6:43 p.m., Andrew Schwartzmeyer wrote:
> > Is there a pressing need to update this _right now_? As it is, we are waiting for
0.3.6 (MESOS-3394) so that we can converge on a single version of Glog for all platforms.
> 
> Tomasz Janiszewski wrote:
>     Nope. We can wait for 0.3.6. We have merged config.guess that open a way to build
on ARM. I'll discard this PR. I'm not sure if our all issues will be solved in 0.3.6. The
glog patch contains fix for cmake build. I'm not sure if glog 0.3.6 fixes this issue. 
>     I'm going to close this PR.

Awesome. Let's try to make sure we get any fixes we need upstream before 0.3.6 drops. Ideally
we can drop any manual patching :)


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63293/#review189264
-----------------------------------------------------------


On Oct. 25, 2017, 5:28 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63293/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2017, 5:28 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3322
>     https://issues.apache.org/jira/browse/MESOS-3322
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Version 0.3.5 adds support for PowerPC so no patching is required.
> 
> Fixes: MESOS-3322
> Refs: https://github.com/google/glog/releases/tag/v0.3.5
> 
> 
> Diffs
> -----
> 
>   3rdparty/glog-0.3.5.patch ab15bea04d7b8af31a638b7c4ce3256ed2f0df4e 
> 
> 
> Diff: https://reviews.apache.org/r/63293/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message