mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raluca Miclea <rmic...@cloudbasesolutions.com>
Subject Re: Review Request 63239: Ported and enabled Flag Tests on Windows.
Date Thu, 26 Oct 2017 11:01:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/
-----------------------------------------------------------

(Updated Oct. 26, 2017, 11:01 a.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
-------

removed TODO comments


Bugs: MESOS-3437
    https://issues.apache.org/jira/browse/MESOS-3437


Repository: mesos


Description
-------

They worked out of the box.
Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests to fail were
solved.


Diffs (updated)
-----

  3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006 


Diff: https://reviews.apache.org/r/63239/diff/2/

Changes: https://reviews.apache.org/r/63239/diff/1-2/


Testing
-------

Modified Tests:
TEST(FlagsTest, LoadFromEnvironment)
TEST(FlagsTest, DuplicatesFromEnvironment)


Thanks,

Raluca Miclea


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message