mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raluca Miclea <rmic...@cloudbasesolutions.com>
Subject Re: Review Request 63238: Ported and enabled Path Tests on Windows.
Date Thu, 26 Oct 2017 10:56:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63238/
-----------------------------------------------------------

(Updated Oct. 26, 2017, 10:56 a.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
-------

addressed review part 2


Bugs: MESOS-3442
    https://issues.apache.org/jira/browse/MESOS-3442


Repository: mesos


Description (updated)
-------

Used path::join() to join them with the os:PATH_SEPARATOR, which is '\\'
on Windows and '/' elsewhere. When testing path::join() itself, I
constructed path strings using the os::PATH_SEPARATOR for portability.


Diffs (updated)
-----

  3rdparty/stout/tests/path_tests.cpp f8c14d5aefe0b49adb778da784143a328c96183d 


Diff: https://reviews.apache.org/r/63238/diff/3/

Changes: https://reviews.apache.org/r/63238/diff/2-3/


Testing
-------

Modified Tests:
TEST(PathTest, Basename)
TEST(PathTest, Dirname)
TEST(PathTest, Extension)
TEST(PathTest, Join)


Thanks,

Raluca Miclea


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message