mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.
Date Wed, 25 Oct 2017 21:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63212/#review189120
-----------------------------------------------------------




src/linux/fs.hpp
Lines 276 (patched)
<https://reviews.apache.org/r/63212/#comment266048>

    Not "immediate parent", but longest match right?



src/linux/fs.cpp
Lines 236 (patched)
<https://reviews.apache.org/r/63212/#comment266050>

    Can you add some tests to `tests/containerizer/fs_tests.cpp`?



src/linux/fs.cpp
Lines 249 (patched)
<https://reviews.apache.org/r/63212/#comment266049>

    So if the target was "/mnt/foobar" and we had a mount called "/mnt/foo", this would match?
Is that what we want here?



src/linux/fs.cpp
Lines 257 (patched)
<https://reviews.apache.org/r/63212/#comment266047>

    Did you consider using a `Result` and returning `None()` in this case?


- James Peach


On Oct. 23, 2017, 4:43 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63212/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2017, 4:43 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This method allows us to get the mount table entry that contains the
> specified target.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp cbc8bf79083ce2bc34fa698808eaf92764a577a9 
>   src/linux/fs.cpp 40c31a3ad2ccbeb59868c5e2d7b1809c613da8de 
> 
> 
> Diff: https://reviews.apache.org/r/63212/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message