mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.
Date Wed, 25 Oct 2017 19:59:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63253/
-----------------------------------------------------------

(Updated Oct. 25, 2017, 7:59 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Gaston Kleiman, John Kordich, Joseph Wu, and
Li Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

Fixed changes from Gaston (git commit 772c8f5 on 10/02/2017)
for proper operation on Windows. Changed to use new URI methods
introduced as part of MESOS-6705, and used powershell on Windows
to replace "test" command on Linux.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp 5078bd4d70698f5cbd14c971fcecfd58f8467a04 


Diff: https://reviews.apache.org/r/63253/diff/2/

Changes: https://reviews.apache.org/r/63253/diff/1-2/


Testing
-------

Ran mesos-tests on both Windows and Linux with no errors.

Specifically ran mesos-tests with `--gtest_filter=MesosContainerizer/DefaultExecutorTest.*`
to verify that the modified tests ran properly.


Thanks,

Jeff Coffler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message