mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 62877: Added RESOURCE_PROVIDER agent capability.
Date Tue, 24 Oct 2017 18:34:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62877/#review189073
-----------------------------------------------------------



I noticed that we have an agent capabilities test here: https://github.com/apache/mesos/blob/d5630f3412dab3b3464f59c57b7526068ebbcb96/src/tests/protobuf_utils_tests.cpp#L278-L292

I'm not convinced that test is necessary, given how simple the constructor is and the fact
that other tests exercise the MULTI_ROLE capability and would fail if the constructor doesn't
work.
I just wanted to give you a heads up on that test in case you thought it was beneficial and
wanted to add your new capability to it.

- Greg Mann


On Oct. 17, 2017, 11:24 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62877/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 11:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8071
>     https://issues.apache.org/jira/browse/MESOS-8071
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added RESOURCE_PROVIDER agent capability.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
>   src/common/protobuf_utils.hpp ff0fd01b7a20f597ec6cd916f0bd9c41baa5fd51 
>   src/common/protobuf_utils.cpp 04f44f6f63e431c17ec67e234c8da58e7945294d 
> 
> 
> Diff: https://reviews.apache.org/r/62877/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message