mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 61946: Added validation of resource provider operations.
Date Tue, 24 Oct 2017 18:06:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61946/#review189007
-----------------------------------------------------------




src/master/validation.cpp
Lines 2266-2268 (patched)
<https://reviews.apache.org/r/61946/#comment265935>

    This check is not necessary. Even if it passes the validation here, it might fail the
following 'contains' check because some other operation in the same accept call used the resources.
I'll simply remove this check here.


- Jie Yu


On Oct. 18, 2017, 1:51 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61946/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 1:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7594
>     https://issues.apache.org/jira/browse/MESOS-7594
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation of resource provider operations.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.hpp f4925752f20ae8ca4de1d9b4a3d5ffc394db9585 
>   src/master/validation.cpp 01bc2e0ad4de0bad570453cdaafb260c61c511eb 
> 
> 
> Diff: https://reviews.apache.org/r/61946/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message