mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63239: Ported and enabled Flag Tests on Windows.
Date Tue, 24 Oct 2017 09:06:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/#review189034
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63239]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 24, 2017, 7:57 a.m., Raluca Miclea wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63239/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-3437
>     https://issues.apache.org/jira/browse/MESOS-3437
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> They worked out of the box.
> Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests to fail
were solved.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006 
> 
> 
> Diff: https://reviews.apache.org/r/63239/diff/1/
> 
> 
> Testing
> -------
> 
> Modified Tests:
> TEST(FlagsTest, LoadFromEnvironment)
> TEST(FlagsTest, DuplicatesFromEnvironment)
> 
> 
> Thanks,
> 
> Raluca Miclea
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message