mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63224: Fixed the flaky MasterTest.IgnoreOldAgentReregistration.
Date Tue, 24 Oct 2017 04:34:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63224/#review189016
-----------------------------------------------------------



Bad patch!

Reviews applied: [63224]

Failed command: python support/apply-reviews.py -n -r 63224

Error:
2017-10-24 04:34:43 URL:https://reviews.apache.org/r/63224/diff/raw/ [1289/1289] -> "63224.patch"
[1]
error: patch failed: src/tests/master_tests.cpp:8068
error: src/tests/master_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19885/console

- Mesos Reviewbot


On Oct. 23, 2017, 8:52 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63224/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2017, 8:52 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-7726
>     https://issues.apache.org/jira/browse/MESOS-7726
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test did not settle the clock before advancing it, which
> meant that the call to delay had not yet occurred.
> 
> Also updated the test to avoid retries of the registration
> message, which can lead the agent to think it is registered
> after a detection event, although this shouldn't be an issue
> for this test.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp c6906a752dd70f1d76056b7199af5c27b1e6419b 
> 
> 
> Diff: https://reviews.apache.org/r/63224/diff/1/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message