mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 63183: Stopped awaiting the connected event in ports isolator tests.
Date Mon, 23 Oct 2017 09:57:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/#review188929
-----------------------------------------------------------



PASS: Mesos patch 63183 was successfully built and tested.

Reviews applied: `['63183']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63183

- Mesos Reviewbot Windows


On Oct. 20, 2017, 4:27 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63183/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than explicitly waiting for the `connected` scheduler event,
> consistently apply the testing pattern from the default executor
> tests. We expect that the `connected` event happens, but we only
> need to synchronize the test on the `subscribed` event.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b

> 
> 
> Diff: https://reviews.apache.org/r/63183/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
> 
> (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message