mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63213: Added mount propagation support for HOST_PATH volumes.
Date Mon, 23 Oct 2017 06:20:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63213/#review188922
-----------------------------------------------------------



Bad patch!

Reviews applied: [63213, 63212, 63211, 63210, 63200, 63017, 59989, 59988, 59987, 60109]

Failed command: python support/apply-reviews.py -n -r 59988

Error:
2017-10-23 06:20:25 URL:https://reviews.apache.org/r/59988/diff/raw/ [1148/1148] -> "59988.patch"
[1]
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19876/console

- Mesos Reviewbot


On Oct. 23, 2017, 10:16 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63213/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2017, 10:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows a container to declare a host path volume such that the
> mounts under that volume can be propagated in both directions.
> Previously, all volume mounts are default to use host to container
> propagation mode.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 859fdff4d9a0604bc506b08af79075084ae23466 
>   include/mesos/v1/mesos.proto cfd4abd3af1d8c9fbd31659161eada9ec9f92282 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302

>   src/slave/containerizer/mesos/launch.cpp 49f11f1d586672bb46f6eccabcfda9321cc3c607 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp 1d006727e5bf76cc659e862cb64fe3facd608c8c

>   src/tests/mesos.hpp 4b61f2dbd67a5e8a65a6655519c8f03e5d6c6954 
> 
> 
> Diff: https://reviews.apache.org/r/63213/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message