mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 63211: Moved the logic of setting '/' as rslave into the launch helper.
Date Mon, 23 Oct 2017 04:42:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63211/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.


Bugs: MESOS-7306
    https://issues.apache.org/jira/browse/MESOS-7306


Repository: mesos


Description
-------

This patch prepares for the mount propagation support. In the future,
we can no longer set the root mount as rslave bindly because some
mounts need to be shared. Move this logic to the launch helper is a
necessary step. We will add more logic there to selectively mark some
mount as shared, and the rest as slave.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp faf94909f995f7486b5f9cb7532af58a90a9eed3

  src/slave/containerizer/mesos/launch.cpp 49f11f1d586672bb46f6eccabcfda9321cc3c607 


Diff: https://reviews.apache.org/r/63211/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message