mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63084: Fixed missing transformResources cases in master::updateSlave.
Date Sun, 22 Oct 2017 19:34:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63084/#review188914
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63084]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 22, 2017, 5:27 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63084/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Bugs: MESOS-8090
>     https://issues.apache.org/jira/browse/MESOS-8090
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed missing transformResources cases in master::updateSlave.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 
> 
> 
> Diff: https://reviews.apache.org/r/63084/diff/2/
> 
> 
> Testing
> -------
> 
> Connect a mesos agent from 1.3.1 build with oversubscription enabled to a master with
this patch, and verifies that master can properly update over subscribed resources.
> 
> Without this patch master crashes like in MESOS-8090.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message