mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 63084: Fixed missing transformResources cases in master::updateSlave.
Date Sun, 22 Oct 2017 17:27:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63084/
-----------------------------------------------------------

(Updated Oct. 22, 2017, 5:27 p.m.)


Review request for mesos, Benjamin Bannier and Michael Park.


Changes
-------

Fix the `total_resources()` case too.


Summary (updated)
-----------------

Fixed missing transformResources cases in master::updateSlave.


Bugs: MESOS-8090
    https://issues.apache.org/jira/browse/MESOS-8090


Repository: mesos


Description (updated)
-------

Fixed missing transformResources cases in master::updateSlave.


Diffs (updated)
-----

  src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 


Diff: https://reviews.apache.org/r/63084/diff/2/

Changes: https://reviews.apache.org/r/63084/diff/1-2/


Testing
-------

Connect a mesos agent from 1.3.1 build with oversubscription enabled to a master with this
patch, and verifies that master can properly update over subscribed resources.

Without this patch master crashes like in MESOS-8090.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message