mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63084: Fixed a missing transformResources case in master::updateSlave.
Date Sat, 21 Oct 2017 07:51:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63084/#review188893
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Line 6802 (original), 6802 (patched)
<https://reviews.apache.org/r/63084/#comment265869>

    I think we need to also convert the resources in `message_.mutable_total_resources()`
here.



src/master/master.cpp
Lines 6815 (patched)
<https://reviews.apache.org/r/63084/#comment265870>

    I think we should move this up before the `if (hasTotal)`.


- Michael Park


On Oct. 17, 2017, 11:38 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63084/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 11:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Bugs: MESOS-8090
>     https://issues.apache.org/jira/browse/MESOS-8090
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a missing transformResources case in master::updateSlave.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 
> 
> 
> Diff: https://reviews.apache.org/r/63084/diff/1/
> 
> 
> Testing
> -------
> 
> Connect a mesos agent from 1.3.1 build with oversubscription enabled to a master with
this patch, and verifies that master can properly update over subscribed resources.
> 
> Without this patch master crashes like in MESOS-8090.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message