mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63200: Added ContainerMountInfo to avoid pre_exec_commands for mounts.
Date Sat, 21 Oct 2017 06:03:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63200/#review188886
-----------------------------------------------------------



Bad patch!

Reviews applied: [63200, 63017, 59989, 59988, 59987, 60109]

Failed command: python support/apply-reviews.py -n -r 59988

Error:
2017-10-21 06:03:16 URL:https://reviews.apache.org/r/59988/diff/raw/ [1148/1148] -> "59988.patch"
[1]
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19865/console

- Mesos Reviewbot


On Oct. 21, 2017, 4:50 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63200/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2017, 4:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added ContainerMountInfo protobuf in ContainerLaunchInfo. It is used
> by isolators and MesosContainerizer to describe mounts. Previously,
> the additional mounts for each container is specified using
> 'pre_exec_commands', which is not very flexible and slow (requires a
> fork/exec for each mount).
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 689acfcbbb07f071b6195472118a7a7520a44abd 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp ed6556830c1d6a72df22c1780ac77fe7d6225f99

>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp c7fbda55e619052edfa5cd97114544d8fefc3ea5

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp faf94909f995f7486b5f9cb7532af58a90a9eed3

>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 927d95be2c25ceb324acac99edaee24a28a5d59c

>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 25636b50314cb4ea53d1931c97c87c65ecb658a8

>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 42bc2e1245c9c957604e6625244a48a564ca5a8c

>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 949510aba6b1f30a64f5f9a0777a4f03e2701302

>   src/slave/containerizer/mesos/isolators/volume/image.cpp 35966aa9a8702e53fa95b3e045cba9327623b99a

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp ee5ea3dee3be197e923be544aab96806f0adf1cf

>   src/slave/containerizer/mesos/launch.cpp 49f11f1d586672bb46f6eccabcfda9321cc3c607 
> 
> 
> Diff: https://reviews.apache.org/r/63200/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message