mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 63191: Refactored entering the chroot in the container launch.
Date Fri, 20 Oct 2017 21:20:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63191/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Hoisted the platform-dependent chroot code out into a helper function
to improve readability. Improved the error message to always include
the rootfs we attempted to enter.


Diffs
-----

  src/slave/containerizer/mesos/launch.cpp d1372987cfbd3761d344479992b2ca6bb918540c 


Diff: https://reviews.apache.org/r/63191/diff/1/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message