mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.
Date Fri, 20 Oct 2017 16:57:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63076/
-----------------------------------------------------------

(Updated Oct. 20, 2017, 9:57 a.m.)


Review request for mesos, James Peach and Joseph Wu.


Changes
-------

Fixed typo and changed some ASSERT to EXPECT.


Bugs: MESOS-8116
    https://issues.apache.org/jira/browse/MESOS-8116


Repository: mesos


Description
-------

The `CreateDirectoryW` API will fail with a path of 248 characters
exactly, so this needed to be `>=`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/internal/windows/longpath.hpp 446b038b0828c25208dd27f9b7f14ea2d32dfbea

  3rdparty/stout/tests/os/filesystem_tests.cpp 0982fd5d35ae1088ec7e768e55b143166c923f8a 


Diff: https://reviews.apache.org/r/63076/diff/3/

Changes: https://reviews.apache.org/r/63076/diff/2-3/


Testing
-------

Tested on Windows with a patch of exactly 248 characters.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message