mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 63107: Added operation feedback for storage operations.
Date Fri, 20 Oct 2017 12:58:59 GMT


> On Oct. 19, 2017, 3:08 a.m., Jie Yu wrote:
> > src/master/master.cpp
> > Lines 7088-7089 (patched)
> > <https://reviews.apache.org/r/63107/diff/1/?file=1862332#file1862332line7088>
> >
> >     This shouldn't be necessary.

I need to update the allocator with updateSlave here to inform it about the new resources.
Otherwise these new resources would never appear in an offer. That's also the reason why slave->totalResources
has to be changed.


> On Oct. 19, 2017, 3:08 a.m., Jie Yu wrote:
> > src/resource_provider/message.hpp
> > Line 36 (original), 37 (patched)
> > <https://reviews.apache.org/r/63107/diff/1/?file=1862334#file1862334line37>
> >
> >     Not yours, this should probably be `UpdateState`

I'll rebase on https://reviews.apache.org/r/62903/, it'll be UPDATE_STATE then.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63107/#review188618
-----------------------------------------------------------


On Oct. 20, 2017, 2:56 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63107/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2017, 2:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8087
>     https://issues.apache.org/jira/browse/MESOS-8087
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a framework accepts an offer that contains resource provider
> resources with a storage operation (`CREATE_VOLUME`, `DESTROY_VOLUME`,
> `CREATE_BLOCK`, `DESTROY_BLOCK`), the result of this operation cannot
> be guessed and will only be known after the operation has been
> successfully applied by the resource provider.
> This patch introduces the necessary handling for such operations. The
> internal bookkeeping of available resources in the master and agent has
> been updated to update resources only after operation feedback has been
> received. This ensures that converted resources can only be offered
> after the operation was executed by a resource provider.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac 
>   src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6 
>   src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 
>   src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 
>   src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef 
>   src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac 
> 
> 
> Diff: https://reviews.apache.org/r/63107/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message