mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 63076: Windows: Fixed off-by-one error in long path support.
Date Fri, 20 Oct 2017 11:10:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63076/#review188827
-----------------------------------------------------------



PASS: Mesos patch 63076 was successfully built and tested.

Reviews applied: `['63076']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63076

- Mesos Reviewbot Windows


On Oct. 19, 2017, 11:37 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63076/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 11:37 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `CreateDirectoryW` API will fail with a path of 248 characters
> exactly, so this needed to be `>=`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/internal/windows/longpath.hpp 446b038b0828c25208dd27f9b7f14ea2d32dfbea

>   3rdparty/stout/tests/os/filesystem_tests.cpp 0982fd5d35ae1088ec7e768e55b143166c923f8a

> 
> 
> Diff: https://reviews.apache.org/r/63076/diff/2/
> 
> 
> Testing
> -------
> 
> Tested on Windows with a patch of exactly 248 characters.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message