mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 63173: Refactored and fixed `DefaultExecutorTest.CommitSuicideOnKillTask`.
Date Thu, 19 Oct 2017 23:59:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63173/#review188796
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63172, 63173]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 19, 2017, 10:08 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63173/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 10:08 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make this flaky test more readable, and cleaner by not trying to guess
> the order in which task status updates will arrive.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp b3c1d82c8286d96fe20ecb2cb01bc3882cef4940 
> 
> 
> Diff: https://reviews.apache.org/r/63173/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo bin/mesos-tests.sh --gtest_filter="*CommitSuicideOnKillTask*" --gtest_repeat=500
--gtest_break_on_failure` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message