mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 62003: Added `network/ports` isolator nested container tests.
Date Thu, 19 Oct 2017 22:50:32 GMT


> On Oct. 19, 2017, 10:44 p.m., Gaston Kleiman wrote:
> > src/tests/containerizer/ports_isolator_tests.cpp
> > Lines 1133 (patched)
> > <https://reviews.apache.org/r/62003/diff/7/?file=1864211#file1864211line1133>
> >
> >     Nit: I prefer `ASSERT_FALSE(offers->offers().empty());`

Yes `ASSERT_FALSE` is a bit cleaner, but doing it this way will show the numeric actual size,
which is arguably more helpful.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62003/#review188777
-----------------------------------------------------------


On Oct. 17, 2017, 7:15 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62003/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 7:15 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `network/ports` isolator nested container tests using the v1
> TaskGroups API. This tests that rogue port usage by a nested task is
> detected both with and without agent recovery, and that a well-behaved
> task is preserved across agent recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
>   src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 
> 
> 
> Diff: https://reviews.apache.org/r/62003/diff/8/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message