mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 60765: Added basic `network/ports` isolator tests.
Date Thu, 19 Oct 2017 22:41:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60765/#review188782
-----------------------------------------------------------




src/tests/containerizer/ports_isolator_tests.cpp
Lines 142 (patched)
<https://reviews.apache.org/r/60765/#comment265798>

    Have you thought about setting the health checks' grace period to `1` instead of `delay_seconds`?
    
    That'd make the checker start probing right ahead, but ignore failures for the first second.
    
    Meaning that the tests could succeed faster if the tasks are ready before the first second
passes.


- Gaston Kleiman


On Sept. 7, 2017, 2:57 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60765/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to verify that the `network/ports` is able to correctly
> terminate only tasks that use rogue TCP ports.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60765/diff/19/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message