mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63019: Encapsulated common error handling in CSI clients.
Date Thu, 19 Oct 2017 17:53:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63019/#review188715
-----------------------------------------------------------




src/csi/client.cpp
Lines 34-66 (patched)
<https://reviews.apache.org/r/63019/#comment265733>

    I'd suggest we move this logic to upper level. Make the CSI client a dead simple client.


- Jie Yu


On Oct. 17, 2017, 12:37 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63019/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 12:37 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By implementing the validation logic and error handling in
> `mesos::csi::Client`, the implementation of the storage local resource
> provider could be cleaner. In the furute, we could also implement the
> retry logic here.
> 
> 
> Diffs
> -----
> 
>   src/csi/client.cpp e171f030efedc60521053399055d67bf99d3fcd2 
>   src/tests/mock_csi_plugin.hpp b7926c4b4ca980e37131c3e9b227343e80f5c002 
>   src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946 
> 
> 
> Diff: https://reviews.apache.org/r/63019/diff/2/
> 
> 
> Testing
> -------
> 
> make test
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message