mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63001: Updated protobuf definitions related to offer operations.
Date Wed, 18 Oct 2017 20:27:19 GMT


> On Oct. 17, 2017, 5:51 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 2187-2195 (patched)
> > <https://reviews.apache.org/r/63001/diff/4/?file=1859672#file1859672line2187>
> >
> >     We also need to include a unique UUID for each operation status update, so that
the framework can include it when acknowledging updates.
> >     
> >     If we follow the pattern of task status updates, we could include an `optional
bytes uuid` field here.

Hmm I missed the comment here :(. Please see my comments below. How about a wrapper protobuf
that includes an `OfferOperationStatus` and a `optional bytes uuid` that is only used internally
in Mesos, or introduce another protobuf for `resource_provider.Call.UpdateOperationStatus`
instead of reusing this one?


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63001/#review188340
-----------------------------------------------------------


On Oct. 17, 2017, 10:10 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63001/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 10:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, Greg Mann,
Jan Schlicht, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated protobuf definitions related to offer operations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/resource_provider/resource_provider.proto f5a9073075327019fd133bd51265f695ef464845

>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
>   include/mesos/v1/resource_provider/resource_provider.proto e5cbede5b6e57a8641fca1ebfee5454f292cc24c

>   src/messages/messages.proto 0a32b3457e9143a7d48670610ca3e56dd516136f 
>   src/resource_provider/manager.cpp 31fcb789f5ab907511e868c374c49f7457a33ed3 
>   src/resource_provider/validation.cpp d2927227f60ab0d4ae2481ad73a31ee444b48ee0 
>   src/tests/resource_provider_validation_tests.cpp f182bff4670318e9de22c2915c5dbb423a74ad6c

> 
> 
> Diff: https://reviews.apache.org/r/63001/diff/8/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message