mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63116: Mesos UI: fixed use of undefined variable for the pailer title.
Date Wed, 18 Oct 2017 18:47:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63116/#review188548
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Oct. 18, 2017, 5 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63116/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 5 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes the use of an undefined variable to generate the
> pailer's window title in `pailer()`.
> 
> The title used for pailers that read agent files used to be: "path
> (host:port)", it is now "path (agentId)".
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js fa0ad54cbcec7a3b0bea9e2b0dc70a4c3f41e822

> 
> 
> Diff: https://reviews.apache.org/r/63116/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message