mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63093: Moved building docs to `building.md`.
Date Wed, 18 Oct 2017 18:33:00 GMT


> On Oct. 18, 2017, 3 a.m., Vinod Kone wrote:
> > docs/getting-started.md
> > Line 241 (original), 241 (patched)
> > <https://reviews.apache.org/r/63093/diff/1/?file=1861952#file1861952line241>
> >
> >     Should we move this to a "Running Mesos" section/page? This is not technically
"Building Mesos"

I thought about this, because you're right, the examples aren't technically "Building Mesos".
But I posit that we keep them here, as the examples aren't really part of anything else. You
pretty much use the examples to prove that your build worked. It even says:

> The framework binaries will only be available after running `make check`, as
described in the ***Building Mesos*** section above.

However, once we have a "Getting Familiar" page, or something similar, I think it would make
sense to move examples into there (like as part of a tutorial beyond just building). What
do you think?


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63093/#review188469
-----------------------------------------------------------


On Oct. 17, 2017, 7:58 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63093/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 7:58 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The existing "Getting Started" documentation does not cover how to "get
> started" with Mesos, but instead how to build it from source on multiple
> platforms. Also added a link to `configuration.md` in the build
> documentation section too, as it was not obvious.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md da1471e6149d2f7b7313416ade0cd5b20daf8ba7 
>   docs/home.md 6a6bd736367505e00c27e5ecd37a68c8e01efe10 
> 
> 
> Diff: https://reviews.apache.org/r/63093/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message