mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62980: Added link anchors to all website headings.
Date Wed, 18 Oct 2017 18:06:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62980/#review188538
-----------------------------------------------------------


Fix it, then Ship it!




I tested this out locally on my Mac, rebased and with my getting started doc changes just
to test it out. It's all working as expected. Though perhaps instead of black, might a medium
gray look better?


site/source/layouts/basic.erb
Lines 125 (patched)
<https://reviews.apache.org/r/62980/#comment265537>

    s/do we/we do/ right?


- Andrew Schwartzmeyer


On Oct. 13, 2017, 9:58 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62980/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This follows the example of the Middleman documentation and
> uses AnchorJS to inject link anchors to all headings at page
> load time. The styling is basic black to match the styling of
> the header titles.
> 
> 
> Diffs
> -----
> 
>   site/source/assets/css/main.css 83596ddbd833e36b60bdbbd487ebd464b3874119 
>   site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 
> 
> 
> Diff: https://reviews.apache.org/r/62980/diff/2/
> 
> 
> Testing
> -------
> 
> Verified manually using the Docker image to run Middleman in dev mode.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message