mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 62214: Added JavaScript linter.
Date Wed, 18 Oct 2017 11:54:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review188477
-----------------------------------------------------------



PASS: Mesos patch 62214 was successfully built and tested.

Reviews applied: `['62214']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

- Mesos Reviewbot Windows


On Oct. 18, 2017, 11:23 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 11:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -----
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/7/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript file and
checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message