mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.
Date Wed, 18 Oct 2017 09:33:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/#review188467
-----------------------------------------------------------




src/webui/master/static/js/controllers.js
Line 50 (original), 86 (patched)
<https://reviews.apache.org/r/62781/#comment265478>

    This patch introduced an issue where `host` is no longer defined when used in this line.


- Alexander Rojas


On Oct. 6, 2017, 11:05 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62781/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 11:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This path extracts the generation of URLs of agent endpoints to a single
> function.
> 
> Having this logic in just one place makes it easier to modify it, e.g.,
> to make it possible to use the UI via a reverse proxy.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/browse.html c586b9050e14697ca89fabfe636c2d18a4ecf6f5 
>   src/webui/master/static/js/controllers.js cb1f093ea21864eadd0ae32f3c33a7ff88b6fc27

>   src/webui/master/static/js/services.js b99ad685e9614ef77586efb5fa52345fc173e51e 
> 
> 
> Diff: https://reviews.apache.org/r/62781/diff/5/
> 
> 
> Testing
> -------
> 
> Verified that the UI still works when running a master and an agent.
> 
> I tried:
> 
>   * Clicking all the tabs.
>   * Viewing the master/agent logs.
>   * Browsing a task sandbox and reading a file using the pailer.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message