mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 60890: Defined API for launching standalone containers.
Date Wed, 18 Oct 2017 03:52:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60890/#review188449
-----------------------------------------------------------




include/mesos/agent/agent.proto
Lines 230 (patched)
<https://reviews.apache.org/r/60890/#comment265443>

    Can you also docuemnt the HTTP code. For instance, that's the HTTP code if container does
not exists?



include/mesos/agent/agent.proto
Lines 235 (patched)
<https://reviews.apache.org/r/60890/#comment265444>

    Ditto on document HTTP code.



include/mesos/agent/agent.proto
Lines 244 (patched)
<https://reviews.apache.org/r/60890/#comment265445>

    Ditto on document HTTP code.


- Jie Yu


On Oct. 16, 2017, 11:41 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60890/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2017, 11:41 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
>     https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Launching a standalone container is very similar to launching a
> nested container, except that the caller must specify some Resources.
> As such, this patch deprecates some nested container APIs
> and replaces them with more generically named APIs.
> 
> This applies to the Launch, Wait, Kill, and Remove
> (nested) container APIs.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 
>   include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f 
> 
> 
> Diff: https://reviews.apache.org/r/60890/diff/4/
> 
> 
> Testing
> -------
> 
> make
> 
> See later patches in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message