mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.
Date Tue, 17 Oct 2017 13:48:06 GMT


> On Oct. 16, 2017, 5:05 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/utils.cpp
> > Line 75 (original), 75 (patched)
> > <https://reviews.apache.org/r/63035/diff/1/?file=1857535#file1857535line75>
> >
> >     I think we can make `ns::getns` return a `Result<ino_t>`. Returnning `None()`
means the pid does not exist.

I did it in a [separate RR](https://reviews.apache.org/r/63074/).


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63035/#review188154
-----------------------------------------------------------


On Oct. 17, 2017, 1:45 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63035/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2017, 1:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-7504
>     https://issues.apache.org/jira/browse/MESOS-7504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To launch a nested container it might be necessarry to enter parent's
> mnt namespace. `getMountNamespaceTarget()` is used for doing that.
> 
> Previously, `getMountNamespaceTarget` returned a failure when a
> parent's child or grandchild process exited after enumerating child
> processes and before getting mnt namespace for the process. Mesos
> containerizer launches pre-exec hooks that might exit when calling
> `getMountNamespaceTarget` during a subsequent launch of a
> nested container. This commit makes `getMountNamespaceTarget` tolerant
> to blinking child processes.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/utils.cpp ec6d6c79b0f93cabe880cd697094c20e999af4d1 
> 
> 
> Diff: https://reviews.apache.org/r/63035/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> ./src/mesos-tests --gtest_filter=NestedMesosContainerizerTest.ROOT_CGROUPS_DestroyDebugContainerOnRecover
--gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message