mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <>
Subject Re: Review Request 63035: Made `getMountNamespaceTarget` more reliable by ignoring exited childs.
Date Tue, 17 Oct 2017 13:45:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 17, 2017, 1:45 p.m.)

Review request for mesos, Alexander Rukletsov, Jie Yu, and Kevin Klues.

Bugs: MESOS-7504

Repository: mesos


To launch a nested container it might be necessarry to enter parent's
mnt namespace. `getMountNamespaceTarget()` is used for doing that.

Previously, `getMountNamespaceTarget` returned a failure when a
parent's child or grandchild process exited after enumerating child
processes and before getting mnt namespace for the process. Mesos
containerizer launches pre-exec hooks that might exit when calling
`getMountNamespaceTarget` during a subsequent launch of a
nested container. This commit makes `getMountNamespaceTarget` tolerant
to blinking child processes.

Diffs (updated)

  src/slave/containerizer/mesos/utils.cpp ec6d6c79b0f93cabe880cd697094c20e999af4d1 




make check
./src/mesos-tests --gtest_filter=NestedMesosContainerizerTest.ROOT_CGROUPS_DestroyDebugContainerOnRecover
--gtest_break_on_failure --gtest_repeat=100


Andrei Budnik

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message