mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63019: Encapsulated common error handling in CSI clients.
Date Tue, 17 Oct 2017 00:37:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63019/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 12:37 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Fixed CSI client tests.


Summary (updated)
-----------------

Encapsulated common error handling in CSI clients.


Repository: mesos


Description
-------

By implementing the validation logic and error handling in
`mesos::csi::Client`, the implementation of the storage local resource
provider could be cleaner. In the furute, we could also implement the
retry logic here.


Diffs (updated)
-----

  src/csi/client.cpp e171f030efedc60521053399055d67bf99d3fcd2 
  src/tests/mock_csi_plugin.hpp b7926c4b4ca980e37131c3e9b227343e80f5c002 
  src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946 


Diff: https://reviews.apache.org/r/63019/diff/2/

Changes: https://reviews.apache.org/r/63019/diff/1-2/


Testing (updated)
-------

make test


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message