mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Review Request 63060: Add an utility function to output the `csi::Version` protobuf.
Date Tue, 17 Oct 2017 00:35:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

The `operator<<` function for `csi::Version` needs to be put in to the
`::csi` namespace so `stringify()` can find it through ADL. Also, we
expose `::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.


Diffs
-----

  src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887 
  src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238 
  src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa 
  src/csi/utils.hpp PRE-CREATION 
  src/csi/utils.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63060/diff/1/


Testing
-------

make


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message