mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63024: Fixed flakiness in 'ResourceProviderRegistrarTest.AgentRegistrar'.
Date Tue, 17 Oct 2017 00:23:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63024/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 12:23 a.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.


Bugs: MESOS-8095
    https://issues.apache.org/jira/browse/MESOS-8095


Repository: mesos


Description (updated)
-------

This test created an agent registrar which attempted to store its state
in the agent's meta directory before the agent had set up that
directory hierarchy.

This patch adds additional waiting to make sure required directories
have been set up before starting the agent registrar.


Diffs
-----

  src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff 


Diff: https://reviews.apache.org/r/63024/diff/1/


Testing
-------

* without patch running test in repetition under load fails after a few hundred iterations,
* with this patch running test in repetition under load does not fail in a few thousand iterations.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message