mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 62145: Implemented Standalone Container API.
Date Tue, 17 Oct 2017 00:02:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62145/
-----------------------------------------------------------

(Updated Oct. 16, 2017, 5:02 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Fairly major change (the diff of diffs is not informative).  This approach has slightly less
code duplication and makes it possible to use the Nested Container API and Standalone Container
API interchangably for nested containers.


Summary (updated)
-----------------

Implemented Standalone Container API.


Bugs: MESOS-7492
    https://issues.apache.org/jira/browse/MESOS-7492


Repository: mesos


Description (updated)
-------

The Standalone and Nested Container APIs are very similar.
This commit combines the two API implementations by adding a
translation function (i.e. `launchNestedContainer` and 
`launchContainer`) which unpacks the V1 protobuf into fields
which can be passed into a common function (i.e. `_launchContainer`).

The common functions authorize based on the type of container being
launched and it is possible to use both Standalone and Nested
Container APIs interchangably for nested containers.

This approach is somewhat messy for for the `WAIT_(NESTED_)CONTAINER`
calls, as these methods require different return protobufs based on
the original call.


Diffs (updated)
-----

  src/slave/http.hpp 44a95dec4c9b8bb65d712c5538bbd7afffe2cf7b 
  src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b 


Diff: https://reviews.apache.org/r/62145/diff/3/

Changes: https://reviews.apache.org/r/62145/diff/2-3/


Testing
-------

TODO


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message