mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63010: Avoided periodic allocations in persistent volume endpoint tests.
Date Mon, 16 Oct 2017 22:04:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63010/#review188219
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/persistent_volume_endpoints_tests.cpp
Lines 1532 (patched)
<https://reviews.apache.org/r/63010/#comment265236>

    Let's be more accurate about the fact that we need the __allocator__ to have processed
the operation, rather than the master having processed the message.


- Michael Park


On Oct. 15, 2017, 3:41 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63010/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2017, 3:41 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-7998, MESOS-8001 and MESOS-8003
>     https://issues.apache.org/jira/browse/MESOS-7998
>     https://issues.apache.org/jira/browse/MESOS-8001
>     https://issues.apache.org/jira/browse/MESOS-8003
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turn off periodic allocations to avoid the race between
> `HierarchicalAllocator::updateAvailable()` and periodic allocations.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c

> 
> 
> Diff: https://reviews.apache.org/r/63010/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/63015/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message