mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
Date Mon, 16 Oct 2017 21:10:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review188206
-----------------------------------------------------------




src/tests/containerizer/blkio_isolator_tests.cpp
Lines 181 (patched)
<https://reviews.apache.org/r/62579/#comment265229>

    Could you fix this:
    ```
    ../../src/tests/containerizer/blkio_isolator_tests.cpp:181
    Expected: (10u) <= (totalIOServiced.value()), actual: 10 vs 9
    ```


- Gilbert Song


On Sept. 26, 2017, 11:24 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 11:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message