mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 63004: Removed no longer necessary response body output in tests.
Date Mon, 16 Oct 2017 17:19:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63004/#review188158
-----------------------------------------------------------


Ship it!




Nice cleanup :)

- Joseph Wu


On Oct. 15, 2017, 3:41 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63004/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2017, 3:41 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since `AwaitAssertResponseStatusEq` now prints response body in case
> of assertion failure, adding it manually to `AssertionResult` at call
> site is no longer necessary.
> 
> 
> Diffs
> -----
> 
>   src/tests/dynamic_weights_tests.cpp da9b53df935ed790edf85b0f68a5600fa9b955f7 
>   src/tests/master_allocator_tests.cpp f8b315c52fbb7dfca13bb596a9566e9e8fc0ccee 
>   src/tests/master_authorization_tests.cpp d8593d881c3a8ed39136026c06c85608d1b2b172 
>   src/tests/master_quota_tests.cpp f9feb67aba3b8eb56190c9400a5a96f61dd94181 
>   src/tests/registrar_tests.cpp 9caff04cd826430c58234273c01770e80b802fb9 
>   src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6

>   src/tests/resource_provider_manager_tests.cpp c29b89207b0ec24ee287a3a3034f5d1e7cefa3ff

>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
>   src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6 
> 
> 
> Diff: https://reviews.apache.org/r/63004/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/63015/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message